Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Fix regression on call arguments with will_break #2720

Closed
Tracked by #2403
ematipico opened this issue Jun 16, 2022 · 0 comments · Fixed by #2812
Closed
Tracked by #2403

Fix regression on call arguments with will_break #2720

ematipico opened this issue Jun 16, 2022 · 0 comments · Fixed by #2812
Assignees
Labels
A-Formatter Area: formatter I-Staff Implementation: should be in charge of a core member of the team

Comments

@ematipico
Copy link
Contributor

ematipico commented Jun 16, 2022

The PR #2711 introduced a known regression, where there are cases where we have to inspect the arguments and check if they break. This will affect the layout of the formatting

Regressions:

expression(
	/* block comment */
);

runtimeAgent.getProperties(
    objectId,
    false, // ownProperties
    false, // accessorPropertiesOnly
    false, // generatePreview
    (error, properties, internalProperties) => {
      return 1
    },
);
@ematipico ematipico self-assigned this Jun 16, 2022
@ematipico ematipico added A-Formatter Area: formatter I-Staff Implementation: should be in charge of a core member of the team labels Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter I-Staff Implementation: should be in charge of a core member of the team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant