Long sequence expressions

[MichaReiser]

Rome's formatter doesn't break long sequence expressions whereas Prettier does.

Playground

Input

abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsfddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd;

abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf;

Prettier

abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsfddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd;

abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf,
	abcdefghijklkmnopqrstufwkdsf;

Rome

abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsfddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd;

abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf, abcdefghijklkmnopqrstufwkdsf;

Expected

Rome emits the same formatting for long sequence expression as Prettier.

[ematipico]

In this case we don't have anything fancy, the new logic will have to be created from scratch.

This is not a good first issue because it would require to make the AST "flat" and then correctly format. Usually we use recursion to handle these cases but we recently moved away because it's expensive.

If we aim to tackle this, I think we should use the Post-Order solution. (same for chain of call expressions)

[MichaReiser]

In this case we don't have anything fancy, the new logic will have to be created from scratch.

This is not a good first issue because it would require to make the AST "flat" and then correctly format. Usually we use recursion to handle these cases but we recently moved away because it's expensive.

If we aim to tackle this, I think we should use the Post-Order solution. (same for chain of call expressions)

I'm not sure if we need a post order solution here because the formatting only affects the right hand side (and not left hand side of the expression). So it should be possible to use a regular while loop here.