This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Allow Rome to exit with an error code on warnings #4328
nstepien
started this conversation in
Suggestions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
For Rome, all the lint rules we've enabled are set to "warn" instead of "error",
the idea is to help devs differentiate between TS type errors (red) and Rome/ESLint lints (yellow) in their code editor.
I've seen junior devs confuse type and lint issues, so I think it's helpful.
Now the issue is that Rome does not exit with an error code, so CI always passes when warnings are found.
We don't want CI to pass on any warnings.
With ESLint we use the
--max-warnings 0
flag, but there is no equivalent feature in Rome.https://eslint.org/docs/latest/use/command-line-interface#--max-warnings
Bonus point: Rome's logo is yellow🟨 , maybe TS's squiggles should be blue!🟦
Beta Was this translation helpful? Give feedback.
All reactions