-
Notifications
You must be signed in to change notification settings - Fork 126
Use parse method from transform context #287
Use parse method from transform context #287
Conversation
23e4de8
to
4a9ab6f
Compare
Those two values are set by rollup and there is no reason to overwrite them here.
4a9ab6f
to
df762c7
Compare
I updated rollup to 0.56 and the tests are passing now. @lukastaegert This is now ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
is there some sort of config change needed for this. I am using |
I am having the exact same issue as @victoriafrench. Any version later than Edit: |
@victoriafrench If you can confirm that |
This depends on rollup/rollup#1945. It removes acorn as a dependency (though it's still a dev dependency for the tests) and uses the
parse
method that is exposed via thetransform
context instead.fixes #275 (by providing the
acornInjectPlugins
option to rollup)(maybe others?)
closes #237
TODO:
rollup
version to0.56.0
when it has been published