detecting builtins

[jimmywarting]

plugins/packages/node-resolve/src/index.js

Line 167 in 12e1fee

const importeeIsBuiltin = builtins.has(importee);

i see that you are using sindres builtin-modules package to detect if something is builtin

One thing it dose not handle is sub modules and the node protocol, that's what his other related package: is-builtin-module is for... it handles things like node:fs, fs/promises and node:fs/promises

Maybe you want to use is-builtin-module instead?

[shellscape]

If you are sure this is a bug or documentation issue, please take the time to refile this issue using the issue template.

Hey there, thanks for opening an issue - Unfortunately you missed (or may have disregarded) the message about issue templates being required. Because our issue template was removed, we assume that this is a support request, and that's not something we offer here. Also, if you refile, please don't ignore Issue sections. They're in the template because they're useful to the maintainers of this project.

[jimmywarting]

yea, missed it cuz i used "references in a new issue"...

[shellscape]

That's the second time that's bit us. Major GitHub fail there. Do me a solid and plop an appropriate template in there.

[stale]

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ