Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Elasticsearch 7 #301

Open
jkabat opened this issue Apr 15, 2023 · 4 comments
Open

[Feature] Elasticsearch 7 #301

jkabat opened this issue Apr 15, 2023 · 4 comments

Comments

@jkabat
Copy link
Contributor

jkabat commented Apr 15, 2023

Any plan to support ruflin/Elastica:^7 any time soon?

@jkabat
Copy link
Contributor Author

jkabat commented Apr 21, 2023

@sstok maybe I could help with this one - do you have any sidenotes which could speed up the process?

@sstok
Copy link
Member

sstok commented Apr 26, 2023

I haven't used Elasticsearch myself, I know @dkarlovi did most of the work on this integration. Maybe he can provide some help.

@dkarlovi
Copy link
Contributor

@jkabat please feel free to contribute any fixes and features, I haven't really used this library actively since we last spoke in #268. 👍 Thanks!

@jkabat
Copy link
Contributor Author

jkabat commented Apr 27, 2023

@sstok @dkarlovi my preliminary tests show that by allowing ruflin/Elastica:^7.0 everything works as supposed to.

You are even doing tests using that package and elasticasearch v7:
https://github.com/rollerworks/search/blob/v2.0.0-BETA2/composer.json#L53
https://github.com/rollerworks/search/blob/v2.0.0-BETA2/.github/workflows/ci.yaml#L48

It is just not allowed for the single package:
https://github.com/rollerworks/search-elasticsearch/blob/v2.0.0-BETA2/composer.json#L26

Right now Im using my fork and testing my implementation against v7. Ill provide feedback and fixes if necessary.
Thanks again for the hard work on this library.

@sstok sstok added this to the 2.0 milestone Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants