Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Regex ValueMatch #50

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Remove support for Regex ValueMatch #50

merged 1 commit into from
Aug 25, 2017

Conversation

sstok
Copy link
Member

@sstok sstok commented Aug 25, 2017

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Remove support for Regex ValueMatch:

  • This is not supported in Elastic Search, and would cause an inconsistency with other processors.
  • Allowing Regexes without any form of validation opens the system to "Regular expression Denial of Service" attacks.
  • YAGNI, most operations can be solved using begin/ends/contains matches.

As a small bonus this removes the need for all those Query platforms 🤓

@sstok sstok added the BC Break label Aug 25, 2017
@sstok sstok merged commit 7966ed5 into rollerworks:master Aug 25, 2017
@sstok sstok deleted the remove-regex-support branch August 25, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sstok