Refactor WhereBuilder (caching) and mapping #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes rollerworks/search#149 |
* WhereBuilder caching now uses PSR-16 (SimpleCache) instead of Doctrine Cache * Support for configuring a Cache has been removed, the Cache key is now automatically configured based on the FieldSet (name), serialized root ValuesGroup and Field mappings (exception field options) * The CacheWhereBuilder can now be used directly for configuring (no more if statements) * When no Cache implementation is provided caching is disabled rather then an exception is thrown * Configuring Conversions on a WhereBuilder has been removed, the type options now require configuring the column/value conversion Some minor bug fixes and corrections. **Note:** Type conversion configuring was broken due to a wrong FieldType class-reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the FieldSet (name), serialized root ValuesGroup and Field mappings (exception field options)
column/value conversion
Some minor bug fixes and corrections.
Note: Type conversion configuring was broken due to a wrong FieldType class-reference.