Simplify column/value conversion system #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value conversions was introduced when prepared statement parameters were still supported. This functionality however has been removed as it caused to much issues, but the conversion system itself was never updated to this new design. The ValueConversionInterface and ValueConversionInterface are redundant in there purpose, and have been merged together. A ValueConversion is now expected to return a properly formatted and escaped SQL statement. * Rename SqlFieldConversionInterface to ColumnConversion * Rename SqlValueConversion to ValueConversion * Rename ConversionStrategyInterface to StrategySupportedConversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value conversions was introduced when prepared statement parameters were still supported.
This functionality however has been removed as it caused to much issues, but the conversion system itself was never updated to this new design.
The ValueConversionInterface and ValueConversionInterface are redundant in there purpose, and have been merged together. A ValueConversion is now expected to return a properly formatted and escaped SQL statement.
I minor clarification: When no value conversion is set the Doctrine DBAL type transformation is used, this was already done but due to complexity of the code base this was a bit hidden.
SqlFieldConversionInterfacetoColumnConversionSqlValueConversiontoValueConversionConversionStrategyInterfacetoStrategySupportedConversion