Redesign the column mapping configuration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The column mapping system is completely redesigned for speed, a good developer experience and less complexity. A number of unused methods were removed. ## WhereBuilder * setField() now allows to set the mappings for multiple columns more cleanly * setField() no longer accepts types as object (string only) * setField() arguments changed to: $fieldName, $column, $alias, $type * getFieldConversions() and getValueConversions() have been removed as they are not actually used anywhere * Updated and clarified php descriptions ## QueryField * This class now final * Properties are now public (READ-ONLY) for better performance * All getter methods have been removed * The column property now includes the table alias (if any), use tableColumn to get actual column name with alias ## QueryGenerator / QueryPlatformInterface * Internal methods now expect the QueryField rather then the fieldName * The provided fields must be a nested array now `[field-name][mapping-name] => QueryField`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column mapping system is completely redesigned for speed, a good developer experience
and less complexity. A number of unused methods were removed.
WhereBuilder
QueryField
use tableColumn to get actual column name with alias
QueryGenerator / QueryPlatformInterface
[field-name][mapping-name] => QueryField