Allow to map field to multiple columns #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
commented
Nov 29, 2016
| @@ -52,7 +53,7 @@ | |||
| * | |||
| * @param Connection $connection | |||
| * @param QueryPlatformInterface $queryPlatform | |||
| * @param QueryField[] $fields | |||
| * @param array $fields | |||
There was a problem hiding this comment.
All CS will be fixed after merging as there are also other CS problems that need to be resolved.
sstok
commented
Nov 29, 2016
| // Initialize from the search-field configuration. | ||
| if ([] === $mappings) { | ||
| /** @var array $mappings */ | ||
| $mappings = $fieldConfig->getOption('doctrine_dbal_mappings', []); |
There was a problem hiding this comment.
This option needs to be added, tested and documented.
There was a problem hiding this comment.
I actually removed this as there are no related mapping options for DBAL.
And Model mapping is deprecated in the core package.
| ['column' => 'last_name', 'type' => 'string', 'alias' => 'c'], | ||
| ]); | ||
|
|
||
| $whereBuilder->setCombinedField('customer-name', [ |
This is known as the combined field search, eg. name will search in both first and last name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is known as the combined field search, eg. name will search in both first and last name.
TheOnNotSuccessfulTraitneeds to be solved in another pull request (pior to merging this pr).And documentation needs to be updated.
Note: The processFieldValues can be optimized to store all fields as combined-field and removing the is_array check. BUT! This will break with the ORM processor that reuses this class, and even updating the ORM processor will not prevent older versions of the ORM processor to install this version of the DBAL package (with breaking changes). I would rather not take this risk, and leave this as a to-do for RollerworksSearch 2.0 👍
I'm really happy with how easy it turned out to be 😄