From 9e791155dc65c8fda2a1ce95bc48a34fe5bf5097 Mon Sep 17 00:00:00 2001
From: Roman Konecny <rokonecn@microsoft.com>
Date: Thu, 26 Nov 2020 13:32:16 +0100
Subject: [PATCH] Review changes - manickap #3

---
 .gitignore                                             |  3 +++
 .../PerformanceTests/HPackHuffmanBenchmark/Fakes/SR.cs | 10 ----------
 .../HPackHuffmanBenchmark/HPackHuffmanBenchmark.csproj |  9 ++++++---
 3 files changed, 9 insertions(+), 13 deletions(-)
 delete mode 100644 src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/Fakes/SR.cs

diff --git a/.gitignore b/.gitignore
index 7596f954d9512..15c6de9d52edf 100644
--- a/.gitignore
+++ b/.gitignore
@@ -133,6 +133,9 @@ AutoTest.Net/
 # Web workbench (sass)
 .sass-cache/
 
+# BenchmarkDotNet
+BenchmarkDotNet.Artifacts/
+
 # Installshield output folder
 [Ee]xpress/
 
diff --git a/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/Fakes/SR.cs b/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/Fakes/SR.cs
deleted file mode 100644
index 5cae2fa0156ce..0000000000000
--- a/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/Fakes/SR.cs
+++ /dev/null
@@ -1,10 +0,0 @@
-// Licensed to the .NET Foundation under one or more agreements.
-// The .NET Foundation licenses this file to you under the MIT license.
-
-namespace System
-{
-    internal class SR
-    {
-        internal static string @net_http_hpack_huffman_decode_failed => "Huffman-coded literal string failed to decode.";
-    }
-}
diff --git a/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/HPackHuffmanBenchmark.csproj b/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/HPackHuffmanBenchmark.csproj
index baec16559db18..7cdd7dc929803 100644
--- a/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/HPackHuffmanBenchmark.csproj
+++ b/src/libraries/System.Net.Http/tests/PerformanceTests/HPackHuffmanBenchmark/HPackHuffmanBenchmark.csproj
@@ -3,14 +3,17 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net5.0</TargetFramework>
+    <StringResourcesPath>../../../src/Resources/Strings.resx</StringResourcesPath>
     <Nullable>enable</Nullable>
+    <LangVersion>9.0</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>
-    <Compile Include="$(CommonPath)System\Net\Http\aspnetcore\Http2\Hpack\Huffman.cs" Link="Common\System\Net\Http\aspnetcore\Http2\Hpack\Huffman.cs" />
-    <Compile Include="$(CommonPath)System\Net\Http\aspnetcore\Http2\Hpack\HuffmanDecodingException.cs" Link="Common\System\Net\Http\aspnetcore\Http2\Hpack\HuffmanDecodingException.cs" />
+    <Compile Include="$(CommonPath)System\Net\Http\aspnetcore\Http2\Hpack\Huffman.cs"
+             Link="Common\System\Net\Http\aspnetcore\Http2\Hpack\Huffman.cs" />
+    <Compile Include="$(CommonPath)System\Net\Http\aspnetcore\Http2\Hpack\HuffmanDecodingException.cs"
+             Link="Common\System\Net\Http\aspnetcore\Http2\Hpack\HuffmanDecodingException.cs" />
     <Compile Include="Program.cs" />
-    <Compile Include="Fakes\SR.cs" />
   </ItemGroup>
   
   <ItemGroup>