From d39d859308eb42a84560a14d606547c0b95303f2 Mon Sep 17 00:00:00 2001
From: Joe Haddad <joe.haddad@zeit.co>
Date: Thu, 11 Jun 2020 15:02:53 -0400
Subject: [PATCH] Simplify test checks (#14094)

Fixes #14093
---
 test/integration/config/test/index.test.js | 59 +++++-----------------
 test/integration/css/test/index.test.js    |  6 +--
 2 files changed, 13 insertions(+), 52 deletions(-)

diff --git a/test/integration/config/test/index.test.js b/test/integration/config/test/index.test.js
index 6b404eab685639..896e1c20ada752 100644
--- a/test/integration/config/test/index.test.js
+++ b/test/integration/config/test/index.test.js
@@ -53,11 +53,7 @@ describe('Configuration', () => {
 
       await check(
         () => browser.elementByCss('.hello-world').getComputedCss('font-size'),
-        {
-          test(content) {
-            return content === '100px'
-          },
-        }
+        '100px'
       )
     } finally {
       if (browser) {
@@ -75,11 +71,7 @@ describe('Configuration', () => {
           browser
             .elementByCss('.hello-world')
             .getComputedCss('background-color'),
-        {
-          test(content) {
-            return content === 'rgba(0, 0, 255, 1)'
-          },
-        }
+        'rgba(0, 0, 255, 1)'
       )
     } finally {
       if (browser) {
@@ -128,18 +120,11 @@ describe('Configuration', () => {
     try {
       browser = await webdriver(context.appPort, '/webpack-css')
 
-      await check(
-        async () => {
-          const pTag = await browser.elementByCss('.hello-world')
-          const initialFontSize = await pTag.getComputedCss('font-size')
-          return initialFontSize
-        },
-        {
-          test(content) {
-            return content === '100px'
-          },
-        }
-      )
+      await check(async () => {
+        const pTag = await browser.elementByCss('.hello-world')
+        const initialFontSize = await pTag.getComputedCss('font-size')
+        return initialFontSize
+      }, '100px')
 
       const pagePath = join(
         __dirname,
@@ -159,11 +144,7 @@ describe('Configuration', () => {
         await check(
           () =>
             browser.elementByCss('.hello-world').getComputedCss('font-size'),
-          {
-            test(content) {
-              return content === '200px'
-            },
-          }
+          '200px'
         )
       } finally {
         // Finally is used so that we revert the content back to the original regardless of the test outcome
@@ -173,11 +154,7 @@ describe('Configuration', () => {
         await check(
           () =>
             browser.elementByCss('.hello-world').getComputedCss('font-size'),
-          {
-            test(content) {
-              return content === '100px'
-            },
-          }
+          '100px'
         )
       }
     } finally {
@@ -196,32 +173,20 @@ describe('Configuration', () => {
       browser = await webdriver(context.appPort, '/webpack-css')
       await check(
         () => browser.elementByCss('.hello-world').getComputedCss('color'),
-        {
-          test(content) {
-            return content === 'rgba(255, 255, 0, 1)'
-          },
-        }
+        'rgba(255, 255, 0, 1)'
       )
 
       try {
         file.replace('yellow', 'red')
         await check(
           () => browser.elementByCss('.hello-world').getComputedCss('color'),
-          {
-            test(content) {
-              return content === 'rgba(255, 0, 0, 1)'
-            },
-          }
+          'rgba(255, 0, 0, 1)'
         )
       } finally {
         file.restore()
         await check(
           () => browser.elementByCss('.hello-world').getComputedCss('color'),
-          {
-            test(content) {
-              return content === 'rgba(255, 255, 0, 1)'
-            },
-          }
+          'rgba(255, 255, 0, 1)'
         )
       }
     } finally {
diff --git a/test/integration/css/test/index.test.js b/test/integration/css/test/index.test.js
index 3a5d257604c80b..4e8e8cf8873993 100644
--- a/test/integration/css/test/index.test.js
+++ b/test/integration/css/test/index.test.js
@@ -357,11 +357,7 @@ describe('CSS Support', () => {
               browser.eval(
                 `window.getComputedStyle(document.querySelector('.red-text')).color`
               ),
-            {
-              test(content) {
-                return content === 'rgb(128, 0, 128)'
-              },
-            }
+            'rgb(128, 0, 128)'
           )
 
           // ensure text remained