Skip to content

Commit 984893f

Browse files
akpm00sfrothwell
authored andcommitted
scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes
ERROR: do not initialise statics to 0 or NULL torvalds#24: FILE: scripts/pnmtologo.c:77: +static int is_plain_pbm = 0; WARNING: line over 80 characters torvalds#33: FILE: scripts/pnmtologo.c:108: + * between the digits. This is Ok cause we know a PBM can only have a '1' total: 1 errors, 1 warnings, 25 lines checked ./patches/scripts-pnmtologo-fix-for-plain-pbm.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andreas Bießmann <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent ce908bd commit 984893f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Diff for: scripts/pnmtologo.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,11 @@ static unsigned int get_number(FILE *fp)
104104
val = 0;
105105
while (isdigit(c)) {
106106
val = 10*val+c-'0';
107-
/* some PBM are 'broken'; GiMP for example exports a PBM without space
108-
* between the digits. This is Ok cause we know a PBM can only have a '1'
109-
* or a '0' for the digit. */
107+
/*
108+
* Some PBM are 'broken'; GiMP for example exports a PBM without space
109+
* between the digits. This is OK because we know a PBM can only have a
110+
* '1' or a '0' for the digit.
111+
*/
110112
if (is_plain_pbm)
111113
break;
112114
c = fgetc(fp);

0 commit comments

Comments
 (0)