Fix for no JS errors in IE8 and below #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E <= 8) will get a friendly warning message instead of having JavaScript breaking entirely.
|
LGTM. will prepare a release tomorrow. Thanks Zoltan! |
rodneyrehm
added a commit
that referenced
this pull request
Apr 5, 2015
bugfix(init): prevent init for IE8 and below to avoid exception due to bad CSSOM
|
released in 0.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per commentary in #46 , we fixed the js files so they would fail without JS errors. The only thing that appears in the console is a .info() call that states "This script will only work with browsers that have buggy implementations of viewport units and will not polyfill viewport units in older browsers (e.g. IE <= 8)'
If we want to take out the error message, that is fine. Otherwise, the issue has been resolved as per the commentary.