Questions while preparing the test layers

[jmargutt]

POST api/events:

1. where do I find the list of valid values for field "type"?

POST api/events/{id}/layers/{name}

1. what do we do when we want to visualize 2 damage levels instead of 4?
2. for all layers I get this error when uploading, need to specify the schema
   <Response [400]> {'message': ['property type should not exist', 'property features should not exist', 'geojson should not be empty', 'information should not be empty', 'information must be a string']}

[jmargutt]

@gulfaraz

[gulfaraz]

1. where do I find the list of valid values for field "type"?

1. In the API swagger documentation for POST /api/events,
   • Click Schema next to Example Value
   • Expand the value for type, there we can see an Enum array with the valid Event Type values.
     
   • For quick reference, the values are,
     • Tropical Cyclone
     • Conflict
     • Eruption
     • Earthquake
     • Fire
     • Flood
     • Heavy Rain
     • Landslide
     • Tsunami
   • The truest source is to look the code in src/event/event-type.enum.ts

1. what do we do when we want to visualize 2 damage levels instead of 4?

The layers buildings-damage-light, buildings-damage-moderate, buildings-damage-heavy represent 3 levels of building damage.
The layer buildings-damage-none represents no building damage.

These layers are independent of each other in terms of geojson and visualization.
We are free to choose any, none, or all of the above layers to represent building damage in an event.

Below are examples of possible combinations,
3 levels of building damage (by using all layers): buildings-damage-light, buildings-damage-moderate, buildings-damage-heavy
2 levels of building damage (by using a subset of 2): buildings-damage-light, buildings-damage-heavy
1 level of building damage (by using a subset of 1): buildings-damage-moderate

Of course, other combinations are allowed. If the concern is that the level of damage is unclear. Then we can use the information field to display an explanation in the layer popup. The information field supports markdown so it's possible to add external links for detailed sources and also to include images for clarity.

2. for all layers I get this error when uploading, need to specify the schema

POST /api/events/{id}/layers/{name} expects a request body to be in the format,

{
  "geojson": {
    "type": "Feature",
    "geometry": { "type": "Point", "coordinates": [ 125.6, 10.1 ] },
    "properties": { "name": "Dinagat Islands" }
  },
  "information": "Supporting information about this event layer."
}

but the requests made by upload_event_layers.py send a request body in the format,

{
  "type": "Feature",
  "geometry": { "type": "Point", "coordinates": [ 125.6, 10.1 ] },
  "properties": { "name": "Dinagat Islands" }
}

The ADA-API looks for a request body with keys geojson and information but finds type, geometry, and properties. Hence throwing the appropriate error messages.

I was able to create the layers using the code below to replace lines 24-29 in upload_event_layers.py,

layer = layer_file.replace('.geojson', '')
layer_data = json.load(f)
request_body = {}
request_body['geojson'] = layer_data
request_body['information'] = f"Popup Information for layer {layer}"
res = requests.post(f'{host}/api/events/{id}/layers/{layer}', headers=headers, data=json.dumps(request_body))

@jmargutt

[gulfaraz]

I noticed that admin-1 geojson had features with properties "name": "ADANA", "number_damaged_buldings": 0.0, "fraction_damaged_buldings": 0.0

The UI will read the value for name but it will ignore number_damaged_buldings and fraction_damaged_buldings

To fix this, please use,
building_damage instead of number_damaged_buldings
building_damage_percentage instead of fraction_damaged_buldings
and people_affected if available

@jmargutt

[jmargutt]

Hey @gulfaraz , you probably saw that I uploaded some new events over the weekend. Here's my feedback, we can discuss on Thursday but maybe you can start working on something. It's NOT in order of priority, so feel free to pick from easiest to hardest.

1. Zoom in/out buttons and admin level selection disappears from view when "event layers" menu is open. Can we avoid that?
2. Population density layer is barely visible for rural areas (example: Haiti Earthquake), especially with the default zoom level. Can we make it more visible?
3. I did a "stress test" with Cyclone Nargis by uploading a ~50 MB building layer, it is indeed slow to render but not dramatically so. So I'd say about performance we're good.
4. About visualizing different levels of damage (e.g. 2 instead of 4): I saw your answer and I think that's already good. What would be even better (although possibly complicated) is to leave the title of the layer as customizable, if necessary. For example, if I upload only 2 levels of damage, I'd like them to appear as "No / Light Building Damage" and "Moderate / Heavy Building Damage". If too complicated to have the layer name customizable, I'd be happy if you can hard-code this specific scenario, as the 2-level damage assessment is a common thing that we do when we are not super-confident about accuracy.
5. I would change "shade X based on Building Damage" to "shade X based on Damaged Buildings", to be consistent with the key figures on the left menu.
6. Looking at the analyses that are being requested/produced around the Turkey-Syria earthquake, I do see value in adding two additional ways of "shading" the admin layers: "shade X based on People Affected (%)" and "shade X based on Damaged Buildings (%)". The legends of both layers should follow the same logic as before, 5 intervals equally spaced between 0 and the maximum, plus of course a % symbol to indicate the unit.

[gulfaraz]

@jmargutt Thank you for testing and the feedback. Let's review the changes below in our call tomorrow before we merge to the main branch.

1. Zoom in/out buttons and admin level selection disappears from view when "event layers" menu is open. Can we avoid that?

Yes, we can set the menu to overlay on the map instead of reveal. However, this will add a translucent backdrop over the map thus blocking any interaction with the map until the menu is closed.

2. Population density layer is barely visible for rural areas (example: Haiti Earthquake), especially with the default zoom level. Can we make it more visible?

rodekruis/ADA-UI@d21620b improves visiblity of the population density layer. Here is the screenshot with the change,

3. I did a "stress test" with Cyclone Nargis by uploading a ~50 MB building layer, it is indeed slow to render but not dramatically so. So I'd say about performance we're good.

🎉 Glad to read this. Thank you for testing the performance. 👏

4. About visualizing different levels of damage (e.g. 2 instead of 4): I saw your answer and I think that's already good. What would be even better (although possibly complicated) is to leave the title of the layer as customizable, if necessary. For example, if I upload only 2 levels of damage, I'd like them to appear as "No / Light Building Damage" and "Moderate / Heavy Building Damage". If too complicated to have the layer name customizable, I'd be happy if you can hard-code this specific scenario, as the 2-level damage assessment is a common thing that we do when we are not super-confident about accuracy.

rodekruis/ADA-UI@a37d58c adds support for 2 new layers,

1. buildings-damage-none-and-light for No / Light Damage
2. buildings-damage-moderate-and-heavy for Moderate / Heavy Damage

These new layers can be used similarly to the buildings-damage-x layers.

5. I would change "shade X based on Building Damage" to "shade X based on Damaged Buildings", to be consistent with the key figures on the left menu.

As we use Building Damage more often than Damaged Buildings, the key figures on the left menu is renamed to Building Damage. rodekruis/ADA-UI@6f99741 uses Building Damage consistently throughout the app.

6. Looking at the analyses that are being requested/produced around the Turkey-Syria earthquake, I do see value in adding two additional ways of "shading" the admin layers: "shade X based on People Affected (%)" and "shade X based on Damaged Buildings (%)". The legends of both layers should follow the same logic as before, 5 intervals equally spaced between 0 and the maximum, plus of course a % symbol to indicate the unit.

rodekruis/ADA-UI@848f416 adds "shade X based on People Affected (%)" and "shade X based on Building Damage (%)" for shading the admin layers. It also adds these to the admin area popups. And adds the missing value to the key figures on the left menu.

The geojson properties used for these will be people_affected_percentage and building_damage_percentage.