Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHCup version of haskell-language-server doesn't work #2

Closed
6im0n opened this issue Apr 24, 2024 · 12 comments
Closed

GHCup version of haskell-language-server doesn't work #2

6im0n opened this issue Apr 24, 2024 · 12 comments

Comments

@6im0n
Copy link

6im0n commented Apr 24, 2024

🐛 Describe the bug
Problem when using the plugin in intellij IDE

👀 To Reproduce
Steps to reproduce the behavior:

  1. Go to intellij
  2. Open a haskell project
  3. Haskell LSP display an error
  4. See error

🤷 Expected behavior
No error

📸 Screenshots
image

💻 Desktop (please complete the following information):

  • OS: [e.g. Linux, Fedora ]

Additional context
I have installed the lastet version of haskell GHCUP, HSL and stack

@rockofox
Copy link
Owner

I'm pretty sure I've found and fixed the issue.
I've published a new version to the JetBrains Marketplace, until that gets approved you can download the new version here: https://github.com/rockofox/intellij-haskell-lsp/releases/tag/1.2.1

Please reopen if it still doesn't work properly.

@jamesrweb
Copy link

jamesrweb commented Jun 21, 2024

I am using 1.2.1 and get the same issue right now. Can you re-open and investigate @rockofox? I am happy to support if needed.

@rockofox rockofox reopened this Jun 21, 2024
@rockofox
Copy link
Owner

@jamesrweb Do you have haskell-language-server installed on your machine? Are there any errors?

@jamesrweb
Copy link

jamesrweb commented Jun 21, 2024

I investigated and it seems to be a problem with the ghcup version of the LSP. When running that, the plugin throws this error.

When using the brew version, the plugin works fine.

I am assuming this is NOT the plugins issue with that being the case and IS a problem of the ghcup version somehow.

You can close this again, but thank you for your reply and patience and the awesome work 🙏🏻❤️

@infloop
Copy link

infloop commented Jun 22, 2024

@jamesrweb Hey-hey, could you describe what is the issue with ghcup version of the LSP?

@jamesrweb
Copy link

I have no idea 🤷🏻‍♂️. I just know that when I install it with brew it works and when I used ghcup it didn't.

@rockofox rockofox changed the title 🐛 Problem with the plugin in the IDE GHCup version of haskell-language-server doesn't work Jul 12, 2024
@rockofox rockofox pinned this issue Jul 12, 2024
@rockofox
Copy link
Owner

@sumanthegde @develmac Please try the new release. It should work with ghcup-installed language server as well.
It's probably not available on marketplace yet, so I've put up a release here.

@sumanthegde
Copy link

sumanthegde commented Jul 13, 2024

Tried 1.3.1, got this notification: "Haskell Language Server not found. Make sure it is installed properly (and is available in PATH or via ghcup), and restart the IDE." However ~/.ghcup/bin is in PATH, and contains HLS:

haskell-language-server-9.4.8~2.7.0.0 -> ../hls/2.7.0.0/bin/haskell-language-server-9.4.8
haskell-language-server-9.6.4~2.7.0.0 -> ../hls/2.7.0.0/bin/haskell-language-server-9.6.4
haskell-language-server-9.8.2~2.7.0.0 -> ../hls/2.7.0.0/bin/haskell-language-server-9.8.2
haskell-language-server-9.2.8~2.7.0.0 -> ../hls/2.7.0.0/bin/haskell-language-server-9.2.8
haskell-language-server-wrapper-2.7.0.0 -> ../hls/2.7.0.0/lib/haskell-language-server-2.7.0.0/bin/haskell-language-server-wrapper
haskell-language-server-9.4.8 -> haskell-language-server-9.4.8~2.7.0.0
haskell-language-server-9.8.2 -> haskell-language-server-9.8.2~2.7.0.0
haskell-language-server-9.2.8 -> haskell-language-server-9.2.8~2.7.0.0
haskell-language-server-9.6.4 -> haskell-language-server-9.6.4~2.7.0.0
haskell-language-server-wrapper -> haskell-language-server-wrapper-2.7.0.0

@rockofox
Copy link
Owner

rockofox commented Jul 13, 2024

@sumanthegde
I've redone a bunch of logic and properly tested it with a clean GHCup installation this time, and it should work now.

I've pushed a new version (1.3.2) to marketplace (awaiting review) and to a GitHub release

@sumanthegde
Copy link

It's able to connect to HLS now. Thank you!

@rockofox
Copy link
Owner

Great to hear!
I'll close this issue now, as the problem seems to be solved.
Feel free to reach out again if any problems, old or new, arise ^^

@develmac
Copy link

@rockofox not sure why my previous comment is gone, but anyway I also tested it and now it works great! Just amazing, I have been waiting for something like this for years, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants