Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed import of rock.simulation. #14

Closed
wants to merge 1 commit into from
Closed

Removed import of rock.simulation. #14

wants to merge 1 commit into from

Conversation

skasperski
Copy link

Don't know why it was imported and should not depend on simulation in my opinion.

@skasperski
Copy link
Author

@planthaber

@skasperski skasperski mentioned this pull request Sep 18, 2023
Open
@planthaber
Copy link
Contributor

Don't know why it was imported and should not depend on simulation in my opinion.

Did you check this? Could be that some package here depends on a definition in rock-simulation

@chhtz
Copy link
Member

chhtz commented Nov 17, 2023

Don't know why it was imported and should not depend on simulation in my opinion.

Did you check this? Could be that some package here depends on a definition in rock-simulation

tools/smurf depends on simulation/smurf_parser:
https://github.com/rock-cpp/smurf/blob/master/manifest.xml

@planthaber planthaber closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skasperski @planthaber @chhtz