Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified SingleChainPublisher task context ? #2

Open
doudou opened this issue Jun 13, 2017 · 2 comments
Open

simplified SingleChainPublisher task context ? #2

doudou opened this issue Jun 13, 2017 · 2 comments

Comments

@doudou
Copy link

doudou commented Jun 13, 2017

ChainPublisher is basically a loop over a list of chains, but it does not seem that it really has a benefit over having a single-chain publisher component. The latter would be significantly simpler, both internally and as an interface, since it would not need to have a dynamic port anymore.

I would be willing to implement this component, provided that you're not against it ... @maltewi ?

@maltewi
Copy link
Contributor

maltewi commented Jun 28, 2017

Would be fine for me. To clarify, you'd propose to implement an additional component named SingleChainPublisher? @doudou

@doudou
Copy link
Author

doudou commented Jun 28, 2017

Exactly. I'll create a PR. Since I'm using SDF, I've implemented it to support both URDF and SDF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants