Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass more info from log message to java logger #68

Open
gavv opened this issue Apr 3, 2023 · 0 comments
Open

Pass more info from log message to java logger #68

gavv opened this issue Apr 3, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome

Comments

@gavv
Copy link
Member

gavv commented Apr 3, 2023

New libroc API (starting from 0.2), log messages provide more granular information. Instead of three arguments (level, component, message), logging callback in native library now receives a struct roc_log_message, defined here:

https://github.com/roc-streaming/roc-toolkit/blob/271ddf27eb3fae0273b5f8488a3114e70f1acfdb/src/public_api/include/roc/log.h#L58

Consider passing the following fields to jul:

  • file and line (not strictly necessary, generally libroc logs are useful without this information too)
  • time
  • pid and tid (or maybe only tid)
@gavv gavv added enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome api Changes in public API and removed enhancement New feature or request labels Apr 3, 2023
@gavv gavv changed the title Granular log messages Pass more info from log message to java logger May 13, 2023
@gavv gavv added enhancement New feature or request and removed api Changes in public API labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Development

No branches or pull requests

1 participant