Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP improve accept behaviour of incoming packets #9

Closed
hannesm opened this issue Dec 20, 2019 · 1 comment
Closed

UDP improve accept behaviour of incoming packets #9

hannesm opened this issue Dec 20, 2019 · 1 comment

Comments

@hannesm
Copy link
Contributor

hannesm commented Dec 20, 2019

each packet carries a packet_id, and the current implementation requires it to be strictly the next one of the last received. now, in UDP packets may arrive out of order, and if this happens, we discarded all future packets (i.e. not sending back an ack, not storing them anywhere); and wait for the exact next packet (with packet_id being last_received_packet_id + 1). A more optimal strategy could be to accept future packets in a window, ack them, and carry some data structure (list?) with the holes of the packet_id space.

related is the handling of old packet_id: assume the peer send us 5, we acked, they send us 6, and 5 again (since the ACK was lost on the way). currently, we ignore/drop the re-sent 5; whereas a well-behaving implementation should likely re-send the ACK for 5.

@hannesm
Copy link
Contributor Author

hannesm commented Nov 8, 2023

#148 is more accurate, so I'll close this issue.

@hannesm hannesm closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant