Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to implement instead of compile in build.gradle where possible #85

Closed
robstoll opened this issue May 27, 2019 · 2 comments
Closed

switch to implement instead of compile in build.gradle where possible #85

robstoll opened this issue May 27, 2019 · 2 comments
Labels
help wanted
Milestone
0.9.0

Comments

@robstoll
Copy link
Owner

robstoll commented May 27, 2019 •
edited
Loading

Platform (JVM, JS and/or Android): all

Non-Code related feature

IMO it makes sense to use api or implementation instead of compile and testImplementation instead of testCompile.

Following a list of modules which should be depended on with api instead implementation (as we want to propagate them as transitive dependencies to consumers):

  • domain-api-deprecated
  • domain-builders-...
  • api-...
  • verbs-...
  • core-api-...
  • domain-api-...
@robstoll robstoll added this to the 0.9.0 milestone May 27, 2019
@ghost
Copy link

ghost commented Jul 15, 2019

Hi Robert. This is my first time opening a pull request in this project. Please let me know if you have any comments or concerns! :) Here is the link to my PR: #100

@robstoll robstoll assigned ghost Jul 15, 2019
@robstoll
Copy link
Owner Author

implemented by aa7bd06, thanks @kssc0112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@robstoll