Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show the feature value in an explanatory assertion group #720

Closed
robstoll opened this issue Dec 16, 2020 · 0 comments · Fixed by #721
Closed

don't show the feature value in an explanatory assertion group #720

robstoll opened this issue Dec 16, 2020 · 0 comments · Fixed by #721
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Dec 16, 2020

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

if a feature assertion is used in an explanatory assertion group then we should not show the coresponding representation of the feature, because it could be wrong, should not have a relevance as the subject is not available. For instance, we show sometimes that -1 matches where found. Thus:

  • adjust TextFeatureAssertionGroupFormatter don't show representation in case we are in an explanatory assertion group (track again separately).
@robstoll robstoll added this to the 0.15.0 milestone Dec 16, 2020
@robstoll robstoll self-assigned this Dec 16, 2020
@robstoll robstoll linked a pull request Dec 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant