Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for iterableExpectations of api-fluent #651

Closed
3 tasks
robstoll opened this issue Oct 20, 2020 · 2 comments · Fixed by #906
Closed
3 tasks

add samples for iterableExpectations of api-fluent #651

robstoll opened this issue Oct 20, 2020 · 2 comments · Fixed by #906
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 20, 2020

Code related feature

See for the initial request: #624

With this issue we want to add samples for iterableAssertions.kt of api-fluent

Following the things you need to do:

api-fluent

  • create IterableExpectationSamples in apis/fluent-en_GB/atrium-api-fluent-en_GB-common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples
    • add one function per function in iterableExpectations.kt (see AnyExpectationSamples)
    • refer to the sample in the KDoc of the corresponding function in iterableExpectations via @sample (check out toBe in anyExpectations.kt to see how you have to refer to the sample, please add it before @since if there is this annotation)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title add samples for iterbaleAssertions of api-fluent add samples for iterableExpectations of api-fluent Apr 28, 2021
@robstoll robstoll added this to the 0.17.0 milestone May 22, 2021
@robstoll
Copy link
Owner Author

@wordhou can you write a comment here please so that I can assign the issue to you

@robstoll robstoll linked a pull request May 22, 2021 that will close this issue
3 tasks
@wordhou
Copy link
Collaborator

wordhou commented Jun 9, 2021

Sorry I missed your message, I'm going to close this as #906 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants