Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Sequence.asList() #461

Closed
8 tasks
robstoll opened this issue Apr 21, 2020 · 3 comments · Fixed by #565
Closed
8 tasks

add Sequence.asList() #461

robstoll opened this issue Apr 21, 2020 · 3 comments · Fixed by #565
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

Platform (jvm, js, android): all
Extension (none, kotlin 1.3, jdk8): none

Code related feature

expect(sequence).asList().get(20).toBe(2)

Following the things you need to do:

api-fluent

  • provide a fun asList which returns Expect<List<T>> (see asIterable as a guideline)
  • provide a fun asList which expects an assertionCreator-lambda and returns Expect<T> (see asIterable as a guideline)
  • add @since 0.12.0 (adapt to next release version) to KDOC
  • remodel ch.tutteli.atrium.api.fluent.en_GB.ListFeatureAssertionsSpec, extend Spek which includes ListSpec which you create as inner object (see ch.tutteli.atrium.api.fluent.en_GB.IterableAnyAssertionsSpec as a guideline)
    - [ ] add a SequenceSpec where you convert the given list to a sequence and then use asList -> see ch.tutteli.atrium.api.fluent.en_GB.IterableAnyAssertionsSpec.SequenceSpec)

api-infix

  • provide a fun asList which returns Expect<List<T>> (see asIterable as a guideline)
  • provide a fun asList which expects an assertionCreator-lambda and returns Expect<T> (see asIterable as a guideline)
  • add @since 0.12.0 (adapt to next release version) to KDOC
  • remodel ch.tutteli.atrium.api.infix.en_GB.ListFeatureAssertionsSpec, extend Spek which includes ListSpec which you create as inner object (see ch.tutteli.atrium.api.infix.en_GB.IterableAnyAssertionsSpec as a guideline)
    - [ ] add a SequenceSpec where you convert the given list to a sequence and then use asList -> see ch.tutteli.atrium.api.infix.en_GB.IterableAnyAssertionsSpec.SequenceSpec)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@gugatkesheladze
Copy link

i'll work on it

@robstoll
Copy link
Owner Author

@Gugatke un-assign you so that others can take over

@Valefant
Copy link
Collaborator

Valefant commented Sep 1, 2020

I did a similar issue and would work also on this one, if it's ok

@robstoll robstoll linked a pull request Sep 1, 2020 that will close this issue
@robstoll robstoll closed this as completed Sep 1, 2020
@robstoll robstoll added this to the 0.14.0 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants