Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show number of occurrences for contains.inAnyOrder.atLeast(1) #310

Closed
robstoll opened this issue Jan 13, 2020 · 1 comment · Fixed by #934
Closed

don't show number of occurrences for contains.inAnyOrder.atLeast(1) #310

robstoll opened this issue Jan 13, 2020 · 1 comment · Fixed by #934
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Jan 13, 2020

Platform (jvm, js, android): all
Extension (none, kotlin 1.3, jdk8): none

Code related feature

Based on discussion in robstoll/atrium-roadmap#56
We would like to see

◆ contains, in any order: 
  ⚬ an element which:
      »  is less than: 0        (kotlin.Int <1234789>)
        » but no such element was found.

Instead of:

◆ contains, in any order: 
  ⚬ an entry which: 
      » is less than: 0        (kotlin.Int <1234789>)
    ⚬ ▶ number of occurrences: 0
        ◾ is at least: 1

This change shall not affect cases like atLeast(2) or exactly(1)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title don't show number of occurrences for atLeast(1) don't show number of occurrences for contains.inAnyOrder.atLeast(1) Jan 14, 2020
@robstoll
Copy link
Owner Author

@susmithasrimani this isn't an easy one to start with, I suggest you do a good first issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants