Move hasNext() check out of Iterable.all

[robstoll]

Platform (jvm, js, android):all
Extension (none, kotlin 1.3, jdk8): none

Code related feature

Similar to #299 but for Iterable.none and iterable.all. Following an example:

expect: [1, 2, 3, 4]        (java.util.Arrays.ArrayList <1234789>)
◆ does not contain: 
  ⚬ an entry which: 
      » is greater than: 2        (kotlin.Int <1234789>)
    ✘ ▶ number of occurrences: 2
        ◾ is: 0        (kotlin.Int <1234789>)
    ✔ ▶ has at least one element: true
        ◾ is: true

Moreover, it should re-use the hasNext check instead of an own descriptive assertion

[tfesenko]

I'll work on this!

[robstoll]

@tfesenko note that this one is not a good first issue, I would recommend you first implement
#31 to get a bit more into Atrium and come back to this one afterwards

[robstoll]

@tfesenko do you still plan to work on this one? Do you need any help?

[tfesenko]

@robstoll , unfortunately, I won't have the time to work on it right now.

[wordhou]

With #931 merged, this seems like a good target to work on. I believe this is the last place still using createHasElementAssertion(list) rather than _logic.hasNext. I can work on this.

Can I also suggest that in the failure case when the list is empty, we add an explanatory group explaining the conditions being checked. Similar to the notToContain in #722. So for

expect(emptyList<Double>()).all { toBeLessThan(1.0) }

we see

◆ has: a next element
  » all entries: 
    » is greater than: 2.5        (kotlin.Double <76130456>)

instead of just

◆ has: a next element

[robstoll]

@wordhou also think that this is a good next issue and I totally agree, we should still see what went wrong in case the iterable is empty.