Skip to content

Array.asList instead of asIterable #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robstoll opened this issue Oct 6, 2019 · 1 comment · Fixed by #184
Closed

Array.asList instead of asIterable #183

robstoll opened this issue Oct 6, 2019 · 1 comment · Fixed by #184
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 6, 2019

Platform (jvm, jdk8, js, android): all

Code related feature

Currently we provide an asIterable for the different Array types. Yet, it would make more sense if we provide an asList so that one gets functionality such as get(index) as well.

Following the things you need to do:

api fluent-en_GB:

  • change the functions in /apis/fluent-en_GB/atrium-api-fluent-en_GB-common/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/arrayAssertions.kt
    • rename asIterable to asList
    • change return type where Expect<Iterable<E> is used
    • change parameter type of assertionCreator
  • rename ArrayAsIterableAssertionsSpec to ArrayAsListAssertionsSpec and adopt the spec accordingly in specs-common

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@piraces
Copy link
Contributor

piraces commented Oct 6, 2019

I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants