Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and eventually remove NON_INTERACTIVE_BUILD ? #473

Open
traversaro opened this issue Jan 17, 2025 · 2 comments
Open

Deprecate and eventually remove NON_INTERACTIVE_BUILD ? #473

traversaro opened this issue Jan 17, 2025 · 2 comments

Comments

@traversaro
Copy link
Member

traversaro commented Jan 17, 2025

The NON_INTERACTIVE_BUILD variable has confusing semantics (the main changes it does is that it set the EP_UPDATE_DISCONNECTED, see

set_property(DIRECTORY PROPERTY EP_UPDATE_DISCONNECTED 1)
) but this is not documented properly nor widely understood by YCM users. The main reason why it was used was to avoid the checks on git mail and name being set, that were anyhow removed in #472, but then that created more errors down the road (see #225 and #474).

So I think that we should first deprecate it, and then remove it.

@traversaro
Copy link
Member Author

fyi @valegagge @CarlottaSartore

@valegagge
Copy link
Member

giving my two cents, since we are going to remove the forcing of name and email git set, It seems to me a good idea to deprecate and then remove NO_INTERACTIVE_BUILD.

This should fix the issue pointed out here: https://github.com/ami-iit/element_joint-velocity-control/issues/10#issuecomment-2599253213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants