Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect handling of private dependencies in install_basic_package_files() #150

Open
PeterBowman opened this issue Jun 14, 2018 · 2 comments

Comments

@PeterBowman
Copy link
Member

PeterBowman commented Jun 14, 2018

As reported in 0e0d0f5#r29318076, there is an apparently needless check for BUILD_SHARED_LIBS regarding private dependencies of static targets.

https://github.com/robotology/ycm/blob/11f45a366fee3e0f35d847c7cfaa601cc5b9687d/modules/InstallBasicPackageFiles.cmake#L559-L570

If I don't set BUILD_SHARED_LIBS (it's either not defined or set to OFF), but all my libraries are SHARED, private dependencies will be handled anyway. And of course, regardless of the value of said variable, STATIC/SHARED options to add_library() override its behavior. Perhaps the inner else clause should get pulled up and no check for BUILD_SHARED_LIBS be performed at all?

In addition, as reported in #148, targets beyond the first one (passed to the FIRST_TARGET option) will be ignored when using the EXPORT option.

@traversaro
Copy link
Member

fyi @randaz81, this is the problem that affected you.

@randaz81
Copy link
Member

Yes indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants