Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable the icub-model-test on iCub3 #179

Closed
GiulioRomualdi opened this issue Nov 23, 2020 · 3 comments · Fixed by #193
Closed

Reenable the icub-model-test on iCub3 #179

GiulioRomualdi opened this issue Nov 23, 2020 · 3 comments · Fixed by #193
Assignees

Comments

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Nov 23, 2020

As discussed with @traversaro we should reenable the test on icub3 in order to avoid regressions such as robotology/icub-models#70.
This model can be used as desiderata for the joints direction.

cc @traversaro and @Nicogene

@traversaro
Copy link
Member

In particular, it is important because of how the Creo/Simmechanics generation works, the direction of the exported axis and hence the list of joints to keep in the reverseRotationAxis list will change, and without a test that checks if the axis direction is correct, we never know if the model is correctly regenerate.

An example is the PR #172, that contained a new generated model, that cause the regression described in robotology/icub-models#70 .

@Nicogene Nicogene self-assigned this Nov 24, 2020
@GiulioRomualdi
Copy link
Member Author

Hi @traversaro and @Nicogene
Is there any plan for this? I'm really afraid that robotology/icub-models#70 will happen again in the future

@traversaro
Copy link
Member

Hi @GiulioRomualdi, I am not aware if this is already planned to work, probably @Nicogene can provide more info on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants