Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

Spawn the auto-generated iCub raw models in the composite Gazebo models (iCub fixed, iCub on seesaw, ...) #16

Closed
diegoferigo opened this issue Nov 2, 2017 · 8 comments
Assignees
Labels

Comments

@diegoferigo
Copy link
Collaborator

diegoferigo commented Nov 2, 2017

The feature/useGeneratedModels branch will get merged into master after all the tests on the new autogenerated models will be performed.

There are notable changes in the usage of this repository, particularly it is not possible anymore to point the env variables directly on the cloned repo, but at least a CMake configuration step is now required.

The reason is that now there are templated .in files to select the active robot model (which can be only one at a time), that must be specified with the -DDROBOT_NAME CMake option. Further infos on the branch's README.

Currently only icub-fixex-nohands has this support, and it should be extended to all the other models in this repository.
For extending the use of the iCub generated model in composite models like "iCub on seesaw", we need to override the model default joint configuration.

So the changes implemented by this Epic are listed below:

  • Create the model.config.in for all the models which would require it
  • Override model default joint configuration in the root gazebo model or world sdf
@nunoguedelha nunoguedelha changed the title Create the model.config.in for all the models which would require it Spawn the auto-generated iCub raw models in the composite Gazebo models (iCub fixed, iCub on seesaw, ...) Dec 8, 2017
@traversaro
Copy link
Contributor

We encountered this issue with @VenusPasandi : in particular, at the moment if someone wants to use the iCubGazeboV2_5 fixed base model, this is not possible unless you manually modify the icub_fixed_no_hands model.

This is a pity, as we should actually suggest most of the users involved in control-related research activities to use the iCubGazeboV2_5 models as much as possible, as for the icubGazeboSim model we do not have any guarantee of the consistency of the inertial parameters between the SDF model simulated in Gazebo and the URDF model used in the control software (this could be also nicely solved by supporting loading SDF in iDynTree robotology/idyntree#481, but this is another story).

@DanielePucci any chance of getting someone to work on this?

@DanielePucci
Copy link

@traversaro
It seems to me that this is somewhat important since, though not blocking, it slows down the simulation process. As soon as @nunoguedelha finishes writing his thesis, this could be a task after thesis submission

@nunoguedelha
Copy link
Collaborator

ok for me, as soon as the thesis is submitted then.

@traversaro , I don't understand what you mean in your last comment..

We encountered this issue with @VenusPasandi : in particular, at the moment if someone wants to use the iCubGazeboV2_5 fixed base model, this is not possible unless you manually modify the icub_fixed_no_hands model.

today three models can already be used with the URDF generated from CAD: "iCubGenovaV2_5 fixed" (base fixed on a pole), "iCubGenovaV2_5 feet fixed", "iCubGenovaV2_5 standing". What was missing was #18 for overriding the root URDF model joint configuration with the one in the composite model, and robotology/gazebo-yarp-plugins#392 implements one of the required bricks, right?

@nunoguedelha
Copy link
Collaborator

What was missing was

... for spawning the remaining models I mean (iCub sitting on a chair, etc...).

@traversaro
Copy link
Contributor

today three models can already be used with the URDF generated from CAD: "iCubGenovaV2_5 fixed" (base fixed on a pole), "iCubGenovaV2_5 feet fixed", "iCubGenovaV2_5 standing".

This is done using the feature/useGeneratedModels, right?

@traversaro
Copy link
Contributor

What was missing was #18 for overriding the root URDF model joint configuration with the one in the composite model, and robotology/gazebo-yarp-plugins#392 implements one of the required bricks, right?

Yes, @lrapetti is working on it.

@nunoguedelha
Copy link
Collaborator

This is done using the feature/useGeneratedModels, right?

yes. If I remember well, it was not merged yet in the master because of the missing joint reconfiguration and #18.

@gabrielenava
Copy link
Collaborator

gabrielenava commented Aug 26, 2019

Closing. Refer also to #18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants