Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of C++/WinRT #2

Closed
robmikh opened this issue Dec 27, 2023 · 2 comments
Closed

Support newer versions of C++/WinRT #2

robmikh opened this issue Dec 27, 2023 · 2 comments

Comments

@robmikh
Copy link
Owner

robmikh commented Dec 27, 2023

Newer versions of C++/WinRT have changed the way coroutine support is handled. I've already had to put together at least one workaround for Win32CaptureSample.

The other header that needs to be fixed is imaging, since it (sloppily) uses std::future to return a winrt::com_ptr. Replacing this will also solve the issue of burning a thread for each of those calls. Unfortunately, IAsyncOperation only works for WinRT interfaces, and not for interfaces that only inherit from IUnknown.

Related: robmikh/Win32CaptureSample#67

@jaimecbernardo
Copy link

Hi, I've opened a new issue in CppWinRT: microsoft/cppwinrt#1391
For the meantime, we'll try using the suggested workaround in PowerToys.

@robmikh
Copy link
Owner Author

robmikh commented Aug 26, 2024

This should now be fixed with v0.0.23

@robmikh robmikh closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants