refactor(migrate): acquire lock in a single statement #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! just so i understand, is the current way it's doing it problematic (i.e. causing a bug) or is this just a better way to do it since it's one query vs two? |
|
There's no issues with the current way, just thought this was simpler. |
robinjoseph08
approved these changes
Dec 22, 2018
robinjoseph08
changed the title
|
v0.1.2 has been cut! thanks again! |
|
thanks for your hospitality and happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be accomplished in a single statement.
UPDATE lock SET is_locked = true WHERE id = 'lock' and is_locked = false. You can tell if the unlock was successful by checking if any rows were updated.