Craft3 #8
Merged
Craft3 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jcdarwin !!! This is awesome, thanks so much for your hard work. Let us give this a once over in the AM and we'll merge tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade of the UserManual plugin to work in Craft 3.
Functionality and attribution have been kept as per the Craft 2 version.
There was no licensing specified with the original plugin that I could find, so this branch specifies MIT and credits @RobErskine, but this can be changed if necessary.
I'll be using this Craft3 version from my fork in my projects, but look forward to being able to switch to using this repository once it's merged.
Given that many users will still want access to the original Craft 2 version, you might want to merge this
craft3branch as a separate branch (i.e. still keep it namedcraft3), or merge it onto master, but subsequently include a note in the README about how users can access the Craft 2 version (i.e. via a git tag / commit hash).Any comments welcome.