From 84c5bf2f306f6506f21774f2e39f80f93c5c10a2 Mon Sep 17 00:00:00 2001 From: Rob Calcroft Date: Wed, 15 Feb 2017 20:57:15 +0000 Subject: [PATCH 1/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6f28e3d..dead1b9 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ list. A React Native style object, you can also pass StyleSheet styles to this; they will be flattened. -## `listViewProps{}` +### `listViewProps{}` An object of props that are given to the ListView, this for things like `renderHeader` ### `activeOpacity` `Number` From e8411ab5624e763d8b69fae908401e12a88eeb33 Mon Sep 17 00:00:00 2001 From: Paulo Mogollon Date: Thu, 16 Feb 2017 12:40:24 -0500 Subject: [PATCH 2/2] Fix for selection updates * When a row was selected it was not rerendered. * Enhanced performance issue --- MultiSelect.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MultiSelect.js b/MultiSelect.js index f24f61f..d057b3e 100644 --- a/MultiSelect.js +++ b/MultiSelect.js @@ -26,11 +26,13 @@ class MultiSelect extends Component { } } - shouldComponentUpdate(nextProps) { + shouldComponentUpdate(nextProps, nextState) { // This is a performance check as this sometimes gets updated often - if (nextProps.selectedOptions.length === this.props.selectedOptions.length) { + if (nextProps.selectedOptions === this.props.selectedOptions && + nextState.selectedRows === this.state.selectedRows) { return false; } + return true; }