Skip to content

Commit 966f954

Browse files
authored
Merge pull request #1872 from TruckMap/chore/camera
Refactor TS integration and convert Camera to TS
2 parents e314448 + fec8430 commit 966f954

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+2224
-3500
lines changed

.eslintignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
/plugin/build
1+
/plugin/build
2+
/example
3+
/lib

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Added `your feature` that allows ...
2020
- [ ] I have tested this on a device/simulator for each compatible OS
2121
- [ ] I updated the documentation with running `yarn generate` in the root folder
2222
- [ ] I mentioned this change in `CHANGELOG.md`
23-
- [ ] I updated the typings files (`index.d.ts`)
23+
- [ ] I updated the typings files (`definitions.d.ts`)
2424
- [ ] I added/ updated a sample (`/example`)
2525

2626
## Screenshot OR Video

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ package-lock.json
5858
yarn.lock
5959
/example/yarn.lock
6060

61+
# Compiled
62+
lib
63+
*.tgz
64+
6165
# Expo
6266
.expo
6367

CONTRIBUTING.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,33 @@
11
# Contributing
22

33
## Setup for creating pull requests
4+
45
- Fork this project
56
- In your fork, create a branch, for example: `fix/camera-update`
67
- Add your changes
78
- Push and open a PR with your branch
89

910
## Testing my changes
11+
1012
The metro bundler under `/example` is set up to use the libraries files under root.
1113
Which means, when you change something within `javascript/components/UserLocation.js`
1214
it will be reflected in any scene in example that uses that component.
1315

1416
## Best practices for PR's
17+
1518
- If you add a feature, make sure you add it to the documentation
16-
- If you add an objective-c or java method, make sure you update the declaration file: `index.d.ts`.
19+
- If you add an objective-c or java method, make sure you update the declaration file: `definitions.d.ts`.
1720
- Make sure to use small concise commits
1821
- Use meaningful commit messages
1922
- Make sure to update/ add new tests for your changes
2023
- If you add a new feature make sure to add a scene in `/example` for others to see/ test it
2124

2225
## Documentation
26+
2327
Documentation is generated from code blocks and comments.
2428
It will be auto-generated when you commit changes.
2529
If any changes are generated from your edits, the changed files will need to be added using `git add` before attempting the commit again.
26-
To manually generate the changes, run `npm run generate`.
30+
To manually generate the changes, run `npm run generate`.
2731

2832
Notice, that changing the documentation in the individual <COMPONENT>.md within `/docs` will not suffice.
2933
The correct way is the above described
30-

0 commit comments

Comments
 (0)