This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
fix Java tests for leptronica #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 4, 2019 01:06
nativeWriteBitmap() changes the source pix data. The fix is in test code, because changing the C++ behavior may break some code that relies on it, or call pixEndianByteSwap() to return to original byte order after write. rmtheis#228 (comment) cherry-pick alexcohn/Tesseract4Android@02e0d37
cherry-pick readfile.cpp that always produces 32-bit pix from renard314 source: https://github.com/renard314/tess-two/blob/bb8b785d79810cbc97dbe5147a75c90714b2abca/tess-two/jni/com_googlecode_leptonica_android/readfile.cpp cherry-pick alexcohn/Tesseract4Android@12edb77
see discussion at rmtheis#264 cherry-pick alexcohn/Tesseract4Android@48d4352
default quality (0 is translated to 75) produces too much noise, use 85 is much better cherry-pick alexcohn/Tesseract4Android@cb181a0
we can do this now because for Pix of type Jpeg, we ignore the least significant bit note that we cannot tighten the threshold for testReadMem_jpg because ReadFile.readMem(byte[]) does not use Pix read from Jpeg, but goes through Bitmap in memory via the Android BitmapFactory API. cherry-picks alexcohn/Tesseract4Android@66255b0
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #87 (comment), this PR fixes the Java tests for Leptronica.