Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

Issue 185 #186

Merged
merged 4 commits into from
Dec 6, 2016
Merged

Issue 185 #186

merged 4 commits into from
Dec 6, 2016

Conversation

0xbad1d3a5
Copy link
Contributor

@0xbad1d3a5 0xbad1d3a5 commented Dec 6, 2016

Please let me know if I did something wrong. This is actually my first pull request, lol.

Changes:

  • Add Javadoc comments on what function stop() is able to interrupt.
  • Remove unused code in nativeGetUTF8Text()
  • Fix test case testStop() to work with getHOCRText()
    • Changed implementation as well to use a large image instead of continuously OCRing small images.
    • Add function drawTextNewLines() to generate a large image with multiple lines

Test Run:
by5fd74pek

The image that testStop() will generate now:
test

Xyresic added 4 commits December 6, 2016 03:13
I believe why calling stop() and end() right after each other was
crashing the program. It's because getHOCRText() will try to return the
recognition done up to that point - but if we end() before that
finishes, we will hit problems since end() cleans up TessBaseAPI
…no guarantee that wait() will be called before notify().
@rmtheis
Copy link
Owner

rmtheis commented Dec 6, 2016

This looks great. Thanks for doing this.

Please feel free to create pull requests or issues in the future as you find other bugs and problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants