This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Pass native pointer as parameter #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way proguard won't remove it
| @@ -64,6 +64,3 @@ | |||
| # -keep public interface mypackage.MyInterface | |||
| # -keep public class * implements mypackage.MyInterface | |||
|
|
|||
| -keep class com.googlecode.eyesfree.textdetect.HydrogenTextDetector { | |||
| private long mNative; | |||
There was a problem hiding this comment.
I think we still need to retain this one, right?
There was a problem hiding this comment.
We don't, because HydrogenTestDetector pass pointer in methods: https://github.com/rmtheis/tess-two/blob/master/eyes-two/src/main/java/com/googlecode/eyesfree/textdetect/HydrogenTextDetector.java#L242
|
Yep, looks good to me, I'll plan to merge this. Did the test cases pass with this code? |
|
Yes |
|
Thanks for the contribution. Please feel free to take on any other issues you may run into. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way proguard won't remove it