This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first pull request to an open source project, so please excuse me if I've done anything wrong and I'll fix my mistakes.
I am working on a project, which rapidly uses OCR provided by tess-two, and noticed a memory leak. I narrowed it down and found that, instead of calling setImage(Bitmap), I could create a Pix object myself, call setImage(Pix), and then recycle the Pix object. This fixed the memory leak for me, but I believe this commit will fix the memory leak when using the Bitmap variant of the method. There is no way to recycle the Pix object outside of this call, since it is only used as a temporary local object.
I tested this and it does seem to work, but I am no expert on Tesseract, so please let me know if you see any issues that may arise.
Thanks for your time.