Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification for computed rootOwner in consolidated NFT changes array #117

Open
spenweb opened this issue Jun 30, 2022 · 3 comments
Open

Comments

@spenweb
Copy link
Contributor

spenweb commented Jun 30, 2022

When should a Change object with "field": "rootowner" property (aka rootowner change) be added to the consolidated NFT change array?

I would expect a rootowner change to be added whenever the root owner changes. I see this occurring in the BUY interaction logic but not in the SEND or ACCEPT logic.

Use case

Determine what address owned an NFT at a certain block by looking at the consolidated NFT without having to reference other NFTs.

Reference: rootowner

@adamsteeber
Copy link

A user could SEND an NFT to another NFT that they also own which wouldn't change the rootowner field. Also, a user may ACCEPT a pending resource which does not change the rootowner. If the entity in the ACCEPT interaction is NFT, then I suppose that's a more philosophical question: does ownership change when a parcel is offered or when it is accepted?

@spenweb
Copy link
Contributor Author

spenweb commented Jun 30, 2022

I am more considering the case where the SEND interaction involves sending an NFT to a wallet address. I am not seeing in the consolidator code anywhere that handles this case by adding a Change object where the rootowner field changes.

This is an issue when trying to determine what wallet address (rootowner) owned the NFT at an arbitrary block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@spenweb @adamsteeber and others