Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder cover art setting not applying on Docker container #977

Closed
muchtall opened this issue Sep 16, 2024 · 1 comment
Closed

Folder cover art setting not applying on Docker container #977

muchtall opened this issue Sep 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@muchtall
Copy link
Contributor

Describe the bug
When copying the Settings.json from a Windows installation, and then subsequently running with these settings in Docker, the "Set cover are as the folder's icon" setting does not apply, and appears to be ignored here:

if (!Configuration.Instance.UseCoverAsFolderIcon || Configuration.IsLinux)

Since this is a headless installation which requires some advanced knowledge of the settings involved, I would expect this setting to apply as intended from the JSON. Even though the app is running in Linux via Docker, it's still desired that I be able to populate the directory with the ico and ini files so that I get the custom thumbnail when viewing the data directory in Windows.

I would suggest that the config line above be modified to state this instead:
if (!Configuration.Instance.UseCoverAsFolderIcon)

To Reproduce
Steps to reproduce the behavior:

  1. Install Libation in Windows
  2. Enable "Set cover art as the folder's icon"
  3. Copy Settings.json to the /config volume in the Docker container
  4. Start the Docker container and allow it to download a title
  5. The desktop.ini and Icon.ico files are missing

Expected behavior
The UseCoverAsFolderIcon Settings.json setting should be honored, even if the application isn't running in Windows

Platform
Linux/Docker

@rmcrackan
Copy link
Owner

Your PR is now available in pre-release v11.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants