Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rel=noopener #12

Closed
Galixte opened this issue Sep 6, 2017 · 3 comments
Closed

Include rel=noopener #12

Galixte opened this issue Sep 6, 2017 · 3 comments

Comments

@Galixte
Copy link

Galixte commented Sep 6, 2017

Hi @rmcgirr83,

i discovered this potiential issue: https://mathiasbynens.github.io/rel-noopener/.

Do you know?
whatwg/html#290
https://developers.google.com/web/tools/lighthouse/audits/noopener
https://html.spec.whatwg.org/multipage/links.html#link-type-noopener

On these pages, it proposed to use this kind of codes:

var otherWindow = window.open(); 
otherWindow.opener = null; 
otherWindow.location = URL;
var nouvelOnglet = window.open('https://www.google.fr', '_blank');
nouvelOnglet.opener = undefined;

Browser compliance: https://caniuse.com/#search=noopener & https://caniuse.com/#search=noreferrer

The future solution: https://www.w3.org/TR/CSP/#directive-disown-opener?

What do you think?

@rmcgirr83
Copy link
Owner

First I don't read nor comprehend French. Second I think it's a non issue.

@Galixte
Copy link
Author

Galixte commented Sep 6, 2017

Links in french aren’t very important, first links are. :)

And what about this? tinymce/tinymce#3177, especially this: tinymce/tinymce#3177 (comment). Since 4.7.4 version from WordPress the Tiny MCE 4.5 version was updated to integrate this security feature: https://www.tinymce.com/docs/changelog/#version450-november232016 (find noopener ).

@rmcgirr83
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants