Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full proxy support #70

Merged
merged 4 commits into from
Sep 24, 2013
Merged

Add full proxy support #70

merged 4 commits into from
Sep 24, 2013

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Sep 10, 2013

This is a continuation (and rebase) of #68 so far for coding standards and commit messages.

@rmccue rmccue mentioned this pull request Sep 10, 2013
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.34%) when pulling f5e1aa3 on proxy into dec780a on master.

@ozh
Copy link
Collaborator

ozh commented Sep 10, 2013

Not sure how/if you want me to continue contributing to this, since you closed my PR...

@ozh
Copy link
Collaborator

ozh commented Sep 10, 2013

For the record: project that manages to run a proxy on Travis using nginx and squid (yet seems a bit overkill to me to apt-get so many stuff on every build)

@rmccue
Copy link
Collaborator Author

rmccue commented Sep 10, 2013

Sorry about that, should have mentioned: open up a pull request with that branch set as the target, and I'll pull your commits into it.

@ozh
Copy link
Collaborator

ozh commented Sep 10, 2013

Yes, why make it simple.

@rmccue
Copy link
Collaborator Author

rmccue commented Sep 11, 2013

Apologies, not trying to make it harder, I just want to make sure that it's following the coding standards and such, and it's easier for me to rebase the commits to do that.

rmccue added a commit that referenced this pull request Sep 24, 2013
Add full proxy support, major props @ozh
@rmccue rmccue merged commit edf5e52 into master Sep 24, 2013
@rmccue
Copy link
Collaborator Author

rmccue commented Sep 24, 2013

@ozh I think I've found a solution that'll work nicely for testing (mitmproxy), but it may take a while to get the tests up and running for that. Merging in the meantime so that this doesn't languish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants