Support a Requests_Proxy_HTTP() instance for the proxy setting. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocean90 Can you fix the unit test for this too please? |
|
@rmccue On it. |
Current coverage is 92.22%@@ master #223 diff @@
==========================================
Files 21 21
Lines 1769 1761 -8
Methods 156 156
Messages 0 0
Branches 0 0
==========================================
- Hits 1631 1624 -7
+ Misses 138 137 -1
Partials 0 0
|
|
Wonderful, thanks! |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 13, 2016
Fixes an issue where you couldn't set a `Requests_Proxy_HTTP` object as a proxy setting. See WordPress/Requests#223. See #37107, #33055. Built from https://develop.svn.wordpress.org/trunk@38053 git-svn-id: http://core.svn.wordpress.org/trunk@37994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Jul 13, 2016
Fixes an issue where you couldn't set a `Requests_Proxy_HTTP` object as a proxy setting. See WordPress/Requests#223. See #37107, #33055. Built from https://develop.svn.wordpress.org/trunk@38053 git-svn-id: http://core.svn.wordpress.org/trunk@37994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dustinrue
pushed a commit
to openfcci/wordpress
that referenced
this pull request
Jul 14, 2016
Fixes an issue where you couldn't set a `Requests_Proxy_HTTP` object as a proxy setting. See WordPress/Requests#223. See #37107, #33055. Built from https://develop.svn.wordpress.org/trunk@38053 git-svn-id: http://core.svn.wordpress.org/trunk@37994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
staylor
pushed a commit
to staylor/develop.svn.wordpress.org
that referenced
this pull request
Aug 18, 2016
Fixes an issue where you couldn't set a `Requests_Proxy_HTTP` object as a proxy setting. See WordPress/Requests#223. See #37107, #33055. git-svn-id: https://develop.svn.wordpress.org@38053 602fd350-edb4-49c9-b593-d223f7449a82
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Feb 16, 2017
Fixes an issue where you couldn't set a `Requests_Proxy_HTTP` object as a proxy setting. See WordPress/Requests#223. See #37107, #33055. git-svn-id: https://develop.svn.wordpress.org/trunk@38053 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://core.trac.wordpress.org/attachment/ticket/37107/37107.diff and https://github.com/rmccue/Requests/blob/2781cddf860322d5441362faf08ebc533619dbcd/library/Requests.php#L325-L326.