Add byte limit option #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option `response_byte_limit` limit response body to an arbitrary number of bytes New class CONST: CHUNK, replacing previously hardcoded value 1160 sockets, used also with cURL
This makes more sense and will help understand the code in the future
Conflicts: library/Requests/Transport/cURL.php
Rather than limiting afterwards, stream to a function and handle it ourselves. This also works better when streaming to files.
Simplify, simplify, simplify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues @ozh's PR from #147, but with master merged so the tests are running up-to-date.