Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention two PHP extension dependencies in the README. #136

Merged
merged 1 commit into from
Dec 24, 2014
Merged

Mention two PHP extension dependencies in the README. #136

merged 1 commit into from
Dec 24, 2014

Conversation

orlitzky
Copy link
Contributor

The PHP cURL extension is needed for the library itself, as can be
seen e.g. by the use of all the CURL_FOO constants. When compiling PHP
from source, this is an optional extension, so we mention it in the
README.

The test suite requires the additional JSON extension, for the
json_decode() function called throughout the suite. This is now
mentioned in the README as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2324774 on orlitzky:master into d02c5d3 on rmccue:master.

@miquelfire
Copy link
Contributor

This library doesn't need cURL, it's an optional dependency. If cURL is not installed, it uses PHP's sockets.

@orlitzky
Copy link
Contributor Author

You're right, sorry! I'll see if I can nuke that commit with another one without the cURL stuff.

The test suite requires the additional JSON extension, for the
json_decode() function called throughout the suite. This is now
mentioned in the README as well.
@rmccue
Copy link
Collaborator

rmccue commented Dec 24, 2014

Thanks! 🎄 🎁

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling a9b88f8 on orlitzky:master into d02c5d3 on rmccue:master.

rmccue added a commit that referenced this pull request Dec 24, 2014
Mention two PHP extension dependencies in the README.
@rmccue rmccue merged commit ea37f1e into WordPress:master Dec 24, 2014
@jrfnl jrfnl modified the milestones: 1.7.1, 1.7 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants