Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check cookie expirations #130

Merged
merged 14 commits into from
Oct 14, 2015
Merged

Actually check cookie expirations #130

merged 14 commits into from
Oct 14, 2015

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Dec 1, 2014

Fixes #129.

  • Parse Expires attribute from cookie header
  • Parse Max-Age attribute from cookie header
  • Add ability to check cookie time validity
  • Check cookies are valid before sending

@rmccue
Parse expiration and max-age from cookies
efdf65e
@rmccue
Allow passing an alternative reference time
4365b7f 
This allows testing relative timestamps, and will also allow better
usage once we move on to actually checking the expiration.
@rmccue
Add tests for cookie parsing
d52292f
@rmccue rmccue added this to the 1.7 milestone Dec 1, 2014
@rmccue rmccue added the Extras label Dec 1, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.19%) when pulling d52292f on cookie-expiry into 3244985 on master.

rmccue added a commit that referenced this pull request Oct 14, 2015
@rmccue
Merge pull request #130 from rmccue/cookie-expiry
9d09968 
Actually check cookie expirations
@rmccue rmccue merged commit 9d09968 into master Oct 14, 2015
@rmccue rmccue deleted the cookie-expiry branch October 14, 2015 04:43
@rmccue rmccue mentioned this pull request Oct 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extras
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

Check cookie expiration
2 participants
@rmccue @coveralls