forked from redhat-developer/odo
-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathodo-model.json
424 lines (424 loc) · 15.4 KB
/
odo-model.json
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
{
"summary": {
"title": "odo Threat Model",
"owner": "Rodolfo Napoles"
},
"detail": {
"contributors": [],
"diagrams": [
{
"title": "odo CLI",
"thumbnail": "./public/content/images/thumbnail.stride.jpg",
"diagramType": "STRIDE",
"id": 0,
"$$hashKey": "object:20",
"diagramJson": {
"cells": [
{
"type": "tm.Actor",
"size": {
"width": 160,
"height": 80
},
"position": {
"x": 39,
"y": 76
},
"angle": 0,
"id": "eaf791db-bdcf-4a6a-9d90-201016660fe8",
"z": 1,
"hasOpenThreats": false,
"threats": [],
"description": "Developer using odo CLI",
"attrs": {
".element-shape": {
"class": "element-shape hasNoOpenThreats isInScope"
},
"text": {
"text": "developer"
},
".element-text": {
"class": "element-text hasNoOpenThreats isInScope"
}
}
},
{
"type": "tm.Store",
"size": {
"width": 160,
"height": 80
},
"position": {
"x": 342,
"y": 410
},
"angle": 0,
"id": "14049148-be25-4123-a79f-df10c5e34264",
"z": 2,
"hasOpenThreats": false,
"attrs": {
".element-shape": {
"class": "element-shape hasNoOpenThreats isInScope"
},
"text": {
"text": "cloned repo"
},
".element-text": {
"class": "element-text hasNoOpenThreats isInScope"
}
}
},
{
"type": "tm.Process",
"size": {
"width": 100,
"height": 100
},
"position": {
"x": 398,
"y": 192
},
"angle": 0,
"id": "fbb7304b-54e9-425a-85f8-edc14c222859",
"z": 3,
"hasOpenThreats": true,
"description": "odo CLI",
"threats": [
{
"ruleId": "c1377855-ea20-4c97-8861-f95c364fb8d2",
"title": "Generic elevation threat",
"type": "Elevation of privilege",
"modelType": "STRIDE",
"status": "Mitigated",
"severity": "Low",
"description": "A generic elevation threat",
"mitigation": "We set least privilege for those files\nFor preferences \n- env (config) file. \n- temporary files\n- preferences file within the user dir\n\nConcerns:\nFrom blog posts users are concerend about privileges in the cluster side (operators can access the secrets from the cluster), level of risk vary between OCP and kubernetes clusters\nOpened issue: https://github.com/redhat-developer/odo/issues/5831\nEnsure we do not allow anything bad even with the minimal rights of the user in the cluster\n\n- Design access control throughout up fornt\n- Force all requests through access control checks\n- Deny by default\n- Follow principle of least privilege\n- Do not hard code roles\n- Log all access control events\n- Eliminate development/debug backdoors in prod. code",
"$$hashKey": "object:495"
},
{
"ruleId": "87bc37e2-798e-4d68-bb96-feb1da26da48",
"title": "Generic repudiation threat",
"type": "Repudiation",
"modelType": "STRIDE",
"status": "Open",
"severity": "Medium",
"description": "A generic repudiation threat. Ability of user to do things that are not logged or user deleting content from logs or deleting logs",
"mitigation": "Telemetry - We need to check if data is sanatized before we send telemetry data through the hidden command. To ensure there is no risk on the GDPR side.\n\n- Log actions",
"$$hashKey": "object:501"
},
{
"ruleId": "13000296-b17d-4b72-9cc4-f5cc33f80e4c",
"title": "Generic information disclosure threat",
"type": "Information disclosure",
"modelType": "STRIDE",
"status": "Open",
"severity": "High",
"description": "A generic information disclosure threat (API keys, PPI)",
"mitigation": "Telemetry - We need to check if data is sanatized before we send telemetry data through the hidden command. To ensure there is no risk on the GDPR side.\nService bindibg, we use secrets we must give the users toos to not disclose the secrets. Ensure secrets do not get stored in logs.\nUpdate documentation to urge the user to use binding as files instead of env variables:\nhttps://github.com/redhat-developer/odo/issues/5890\n\nWrite integration test to verify secrets are not written into the logs.\nhttps://github.com/redhat-developer/odo/issues/5889\n\n- Avoid writting PII and token/keys into log files",
"$$hashKey": "object:515"
},
{
"ruleId": "edb05d76-a695-455f-947b-7d67b78bc31d",
"title": "Generic DoS threat",
"type": "Denial of service",
"modelType": "STRIDE",
"status": "Open",
"severity": "Low",
"description": "A generic DoS threat. Through buffer overflow",
"mitigation": "There is an issue open for input validation already:\nhttps://github.com/redhat-developer/odo/issues/5765\n\n- Input validation\n- check buffer sizes\n- ru code using lowest privileges to accomplish required tasks",
"$$hashKey": "object:521"
},
{
"ruleId": "c1377855-ea20-4c97-8861-f95c364fb8d2",
"title": "OS command injection",
"type": "Elevation of privilege",
"modelType": "STRIDE",
"status": "Open",
"severity": "Medium",
"description": "OS command injection",
"mitigation": "- Proper input validation:\nhttps://github.com/redhat-developer/odo/issues/5765\n\n- Contextually escape user data",
"$$hashKey": "object:475"
},
{
"status": "Open",
"severity": "Medium",
"modelType": "STRIDE",
"title": "Main in the middle attack",
"type": "Tampering",
"description": "When communicating with any external services, like devfile registry, kubernetes API service, startup projects, any UI in the devfile, etc.",
"mitigation": "Ensure we user secure communication channels / use of encryption.\nEnsure we use the secure flag to true\nhttps://github.com/redhat-developer/odo/issues/5888",
"$$hashKey": "object:531"
}
],
"attrs": {
".element-shape": {
"class": "element-shape hasOpenThreats isInScope"
},
"text": {
"text": "odo CLI"
},
".element-text": {
"class": "element-text hasOpenThreats isInScope"
}
}
},
{
"type": "tm.Boundary",
"size": {
"width": 10,
"height": 10
},
"smooth": true,
"source": {
"x": 405,
"y": 79
},
"target": {
"x": 182,
"y": 455
},
"vertices": [
{
"x": 244,
"y": 166
},
{
"x": 194,
"y": 353
}
],
"id": "29e20af7-aa72-40b3-8147-74b809dc4b4d",
"z": 4,
"attrs": {}
},
{
"type": "tm.Boundary",
"size": {
"width": 10,
"height": 10
},
"smooth": true,
"source": {
"x": 630,
"y": 633
},
"target": {
"x": 925,
"y": 269
},
"vertices": [
{
"x": 643,
"y": 505
},
{
"x": 746,
"y": 310
}
],
"id": "7d6cf5b7-f53e-4de4-a581-1c7290969f66",
"z": 5,
"attrs": {}
},
{
"type": "tm.Process",
"size": {
"width": 100,
"height": 100
},
"position": {
"x": 798,
"y": 378
},
"angle": 0,
"id": "4931bd53-6796-49c0-8da1-0055ad40329b",
"z": 6,
"hasOpenThreats": false,
"attrs": {
".element-shape": {
"class": "element-shape hasNoOpenThreats isInScope"
},
"text": {
"text": "cluster"
},
".element-text": {
"class": "element-text hasNoOpenThreats isInScope"
}
}
},
{
"type": "tm.Flow",
"size": {
"width": 10,
"height": 10
},
"smooth": true,
"source": {
"id": "eaf791db-bdcf-4a6a-9d90-201016660fe8"
},
"target": {
"id": "fbb7304b-54e9-425a-85f8-edc14c222859"
},
"vertices": [
{
"x": 219,
"y": 157
},
{
"x": 259,
"y": 177
},
{
"x": 317,
"y": 200
},
{
"x": 338,
"y": 207
},
{
"x": 354,
"y": 214
},
{
"x": 369,
"y": 216
}
],
"id": "92c54ac0-1c14-4b25-ac82-df17ccd6ca9c",
"labels": [
{
"position": 0.5,
"attrs": {
"text": {
"text": "flow 6",
"font-weight": "400",
"font-size": "small"
}
}
}
],
"z": 7,
"hasOpenThreats": false,
"attrs": {
".marker-target": {
"class": "marker-target hasNoOpenThreats isInScope"
},
".connection": {
"class": "connection hasNoOpenThreats isInScope"
}
}
},
{
"type": "tm.Flow",
"size": {
"width": 10,
"height": 10
},
"smooth": true,
"source": {
"id": "fbb7304b-54e9-425a-85f8-edc14c222859"
},
"target": {
"id": "4931bd53-6796-49c0-8da1-0055ad40329b"
},
"vertices": [
{
"x": 581,
"y": 295
},
{
"x": 598,
"y": 301
},
{
"x": 631,
"y": 318
},
{
"x": 680,
"y": 344
}
],
"id": "37d834fd-3677-4735-808c-297471b170f1",
"labels": [
{
"position": 0.5,
"attrs": {
"text": {
"text": "flow 7",
"font-weight": "400",
"font-size": "small"
}
}
}
],
"z": 8,
"hasOpenThreats": false,
"attrs": {
".marker-target": {
"class": "marker-target hasNoOpenThreats isInScope"
},
".connection": {
"class": "connection hasNoOpenThreats isInScope"
}
}
},
{
"type": "tm.Flow",
"size": {
"width": 10,
"height": 10
},
"smooth": true,
"source": {
"id": "fbb7304b-54e9-425a-85f8-edc14c222859"
},
"target": {
"id": "14049148-be25-4123-a79f-df10c5e34264"
},
"vertices": [
{
"x": 435,
"y": 312
},
{
"x": 429,
"y": 382
}
],
"id": "d313eea9-5751-4952-970b-ad6e2be4af75",
"labels": [
{
"position": 0.5,
"attrs": {
"text": {
"text": "flow 8",
"font-weight": "400",
"font-size": "small"
}
}
}
],
"z": 9,
"hasOpenThreats": false,
"attrs": {
".marker-target": {
"class": "marker-target hasNoOpenThreats isInScope"
},
".connection": {
"class": "connection hasNoOpenThreats isInScope"
}
}
}
]
},
"size": {
"height": 659,
"width": 3130
}
}
],
"reviewer": "ODO Team"
}
}